-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): fire touch events synchronously #12340
Conversation
Fixes TIMOB-28286
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed, tested using the two test cases mentioned above.
Test Environment
MacOS Big Sur: 11.1 Beta 1
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
N3xus 5X API 29 (emulator)
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28286
Summary:
Modified
touchstart
,touchmove
,touchend
, andtouchcancel
events to fire immediately/synchronously like iOS. Needed to implement drag-and-drop interface so it won't look jumpy/laggy.Test 1:
Test 2:
(Verifies touch events bubbled to parent.)